Fix loading spinner sizing #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The loading spinner was not sized to the actual element's size due to the units being used incorrectly.
Contributor
Author
|
You may have to undo the build steps to merge multiple pull requests, so feel free to do that on the provided branch. |
lucaslarroche
approved these changes
Mar 3, 2024
Member
lucaslarroche
left a comment
There was a problem hiding this comment.
@FireIsGood, thank you.
Great change! I will merge your PR and release a new patch later today.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #469
Previously, the spinner would not resize to match its width and height. This was due to the wrong unit being used for the background image.
Comparison
(Outlines added on these images for clarity, but not actually in the changes)
Before:
After:
Info for CSS nerds
This is a single character change to make
1reminto1em. The difference is thatremdoes not scale with the element's font size compared toem. The width and height of the element are set withem, so changing this makes it scale to fit the box correctly.