Skip to content

Allow use of card component with role="article" - #548

Open
lukas-kasticky wants to merge 1 commit into
picocss:devfrom
lukas-kasticky:dev
Open

Allow use of card component with role="article"#548
lukas-kasticky wants to merge 1 commit into
picocss:devfrom
lukas-kasticky:dev

Conversation

@lukas-kasticky

@lukas-kasticky lukas-kasticky commented May 25, 2024

Copy link
Copy Markdown

Would be a welcome improvement. It's a valid ARIA role and makes things like <fieldset role="article"><!-- ... --></fieldset> possible. Any reasons not to do this?

@ginger-tek

Copy link
Copy Markdown

Would wrapping the element in an <article> do the same thing visually? Probably not semantic, so I get the reasoning for the role="article", though I propose role="card" instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants