refactor: move nested sass declarations after non-nested declarations - #596
Conversation
|
Sad at the number of files that needed touching but happy that you might have uncovered the issue and solved it. |
|
If you want I can move |
|
This is a great PR to be honest, I was getting the same issue and was going to create the PR, but @nstringham already did it. Awesome! When do we get this? |
|
I'm currently using "@picocss/pico": "^2.0.6", within my npm workspace. What version of picocss do we need to update to, to overcome these Deprecation Warnings? |
You need to wait until this PR is merged. |
just a super nit. I think it's great! |
|
@lucaslarroche Can you look at this please? This warnings are very annoying! |
problem ------ we get a pile of css deprecation warnings solution ------ Follow the instructions from the warnings to get quiet them up. changes ------- * Applied Pico PR's (via patch) picocss#575 and picocss#596 * Update sass files to include `sass:color`, `sass:list` etc as required to avoid global methods * Move from `color.red`, `color.green`, `color.blue` to `color.channel` as suggested by deprecation warnings * bumped sass to 1.81 * rebuild css (with `yarn build`)
|
Hey @nstringham, This will allow us to remove Appreciate the contribution! |
|
Thanks! |
This PR fixes #577 by reordering some sass declarations to work with the new rules for mixed declarations. See https://sass-lang.com/documentation/breaking-changes/mixed-decls for more info.