Skip to content

Style the samp element like code - #644

Merged
lucaslarroche merged 1 commit into
picocss:devfrom
ISSOtm:patch-1
Mar 9, 2025
Merged

Style the samp element like code#644
lucaslarroche merged 1 commit into
picocss:devfrom
ISSOtm:patch-1

Conversation

@ISSOtm

@ISSOtm ISSOtm commented Dec 14, 2024

Copy link
Copy Markdown
Contributor

Following Pico's philosophy of “give semantic HTML good styling”, this element has semantics close to but slightly different from <code>, and so I believe should be styled similarly.

(Note: I will recompile the css/ files if/when this change is at least agreed upon in principle.)

Following Pico's philosophy of “give semantic HTML good styling”,
this element has semantics close to but slightly different from `<code>`,
and so I believe should be styled similarly.
@Yohn

Yohn commented Dec 14, 2024

Copy link
Copy Markdown

Hey @ISSOtm

I can see this being helpful, and I'd like to add it to my PicoCSS Fork. If you'd like you can open the pull request there, without compiling the css/ directory and I'll include it in the next release 2.2.1

@lucaslarroche

Copy link
Copy Markdown
Member

Hey @ISSOtm,
Thanks for this! It’s a great addition, and I appreciate your contribution.
Sorry for the delay.
I'll go ahead and merge this into dev and build the CSS files.
This will be included in the next release. 🚀

@lucaslarroche
lucaslarroche marked this pull request as ready for review March 9, 2025 06:57
@lucaslarroche
lucaslarroche merged commit 559213c into picocss:dev Mar 9, 2025
@lucaslarroche lucaslarroche mentioned this pull request Mar 9, 2025
@ISSOtm

ISSOtm commented Mar 10, 2025

Copy link
Copy Markdown
Contributor Author

Thank you! ^^

@ISSOtm
ISSOtm deleted the patch-1 branch March 10, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants