maj pol.scss

[rcuisnier]

Great Work !

1- I propose to invert the colors since it is white above red :
I dont know if the ratio should also be 4/8 instead of 5/8 ?
https://en.wikipedia.org/wiki/Poland

It should also apply here : https://pixelastic.github.io/css-flags/

2- I have a question : for re-using the flags using smaller size because some flags are based on px (ex for great britain) could it rely on % of space instead of px ?

[pixelastic]

Thanks for the Poland reminder. Several polish users told me about it on Twitter, so this is now fixed.

For the ratio both the Wikipedia page and Vexilla Mundi seems to agree on 5:8.

Regarding the px/%, I try to use % as much as I can. Percentage are always relative to a side, so it is easy when using vertical or horizontal stripes. I becomes harder when I need to draw for example a square (where each side must have the exact same length). Then I cannot use percentage (because one would apply to height and the other to width), so it's easier to just use an absolute px value. Same goes for diagonal stripes. I could convert the px value to a % value but I'm afraid it will incurr round errors and make the code harder to read.

Anyway, this code was just a personal challenge, I would not recommend using it in production :)