Skip to content

Select all on click#132

Closed
emtek wants to merge 2 commits intoplentz:masterfrom
emtek:master
Closed

Select all on click#132
emtek wants to merge 2 commits intoplentz:masterfrom
emtek:master

Conversation

@emtek
Copy link

@emtek emtek commented Jun 17, 2014

I had the requirement to select all on click so have added that to my fork.
It does not change the default behaviour

@plentz
Copy link
Owner

plentz commented Jun 17, 2014

@emtek I don't think that this would be very useful the way it is. I think that something like allowing double click to select the content or even allow selection would be more useful for other people. What you think?

@emtek
Copy link
Author

emtek commented Jun 17, 2014

@plentz I agree that all of those ways would be good too but for my current situation I require selection on single click because users are often replacing the values in the fields. Perhaps a set of different behaviors on click? eg selectAll/cursorStart/cursorEnd Or just allow users to specify a function for onClick? If you want me to write it for double click I can go ahead and do that but I won't be using it that way. Thanks for the great plugin :)

@plentz
Copy link
Owner

plentz commented Feb 28, 2015

@emtek sorry for taking so long to reply! I think that the double click is more usefull and more intuitive, since it's the default behaviour of the browser. Could you open a new PR with that change? (btw, try to not change the indentation, it makes it harder to look at the history and see exactly what that commit changes :) )

Thanks a lot for contributing! :)

@plentz plentz closed this Feb 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments