Skip to content

Adding bower.json so that build scripts dependent on the main attribute still work.#141

Merged
plentz merged 2 commits intoplentz:masterfrom
Duder-onomy:master
Feb 28, 2015
Merged

Adding bower.json so that build scripts dependent on the main attribute still work.#141
plentz merged 2 commits intoplentz:masterfrom
Duder-onomy:master

Conversation

@Duder-onomy
Copy link
Contributor

Many people are using your bower listing to include this awesome library into their projects, however, the repo has no bower.json.

This means that people who count on it being there for build scripts cannot use it as a true bower style dependency.

Usually, when a person wants to make a repo on bower, they run bower init This creates the bower.json with reasonable defaults. It is something that users count on being there.

Addition of a bower.json, and in particular, the main attribute of the bower.json, ensures that people can use npm's like main bower files to compile their source code without configuring which file is the actual source file in the repo.

The only issues I can think of by adding this are:

  1. You will need to bump the version number in the bower.json when you make a new release.
  2. You might want to point the main attribute at the minified version instead.

If you accept this pull request you will also need to make a version bump. A patch bump will be sufficient.

@plentz
Copy link
Owner

plentz commented Sep 19, 2014

related #105 :)

plentz pushed a commit that referenced this pull request Feb 28, 2015
Adding bower.json so that build scripts dependent on the main attribute still work.
@plentz plentz merged commit ef4e941 into plentz:master Feb 28, 2015
@plentz
Copy link
Owner

plentz commented Feb 28, 2015

@Duder-onomy thanks a lot! you rock :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments