Adding bower.json so that build scripts dependent on the main attribute still work.#141
Merged
plentz merged 2 commits intoplentz:masterfrom Feb 28, 2015
Merged
Adding bower.json so that build scripts dependent on the main attribute still work.#141plentz merged 2 commits intoplentz:masterfrom
plentz merged 2 commits intoplentz:masterfrom
Conversation
added 2 commits
September 18, 2014 15:27
Owner
|
related #105 :) |
plentz
pushed a commit
that referenced
this pull request
Feb 28, 2015
Adding bower.json so that build scripts dependent on the main attribute still work.
Owner
|
@Duder-onomy thanks a lot! you rock :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many people are using your bower listing to include this awesome library into their projects, however, the repo has no
bower.json.This means that people who count on it being there for build scripts cannot use it as a true bower style dependency.
Usually, when a person wants to make a repo on bower, they run
bower initThis creates thebower.jsonwith reasonable defaults. It is something that users count on being there.Addition of a
bower.json, and in particular, themainattribute of thebower.json, ensures that people can use npm's like main bower files to compile their source code without configuring which file is the actual source file in the repo.The only issues I can think of by adding this are:
bower.jsonwhen you make a new release.mainattribute at the minified version instead.If you accept this pull request you will also need to make a version bump. A patch bump will be sufficient.