Skip to content

Fixing issues with change events (#44)#66

Closed
evindor wants to merge 1 commit intoplentz:masterfrom
evindor:master
Closed

Fixing issues with change events (#44)#66
evindor wants to merge 1 commit intoplentz:masterfrom
evindor:master

Conversation

@evindor
Copy link

@evindor evindor commented Mar 12, 2013

Hi guys! There is a way to fix issues with change events. Since blur is triggering anyways, we can throw out triggering change events on tab and escape keyups and keydowns.

Also, change now is not triggered if user did something(field became dirty), but ended up with the same value.

Sum up:

  • Click out from input now triggers change event
  • Change not triggered now if the value is the same as it was

@plentz
Copy link
Owner

plentz commented Mar 12, 2013

@evindor awesome! I will review this ASAP, but I already saw a problem: you've duplicated the )(jQuery); at the end. Can you update your pull request removing this, pretty please? :)

@evindor
Copy link
Author

evindor commented Mar 13, 2013

Yep, sorry for this 'mispaste'. I've updated the commit.

@vaneves
Copy link

vaneves commented Aug 9, 2013

Thanks, @evindor
@plentz, accept the pull request

@plentz
Copy link
Owner

plentz commented Dec 16, 2013

I'm closing this one to centralize everything related to the change event problem in #44

@plentz plentz closed this Dec 16, 2013
plentz pushed a commit that referenced this pull request Dec 31, 2013
…44 #47 #66 #86 #91

also, closing #13, as we have now a good(not perfect) test suite. fixes #13

to celebrate, I'm launching maskMoney 3.0.0 :-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments