Skip to content

Remove text-decoration hack #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
h3rmanj wants to merge 2 commits into from
+9 −29
Closed

Remove text-decoration hack #1474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d3f759
Remove text-decoration hack
h3rmanj Sep 7, 2022
07f0c1e
Update text-decoration test to verify output
h3rmanj Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions lib/hacks/text-decoration.js
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions lib/prefixes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ let hackFlexDirection = require('./hacks/flex-direction')
let hackImageRendering = require('./hacks/image-rendering')
let hackBackdropFilter = require('./hacks/backdrop-filter')
let hackBackgroundClip = require('./hacks/background-clip')
let hackTextDecoration = require('./hacks/text-decoration')
let hackJustifyContent = require('./hacks/justify-content')
let hackBackgroundSize = require('./hacks/background-size')
let hackGridRowColumn = require('./hacks/grid-row-column')
Expand Down Expand Up @@ -105,7 +104,6 @@ Declaration.hack(hackFlexDirection)
Declaration.hack(hackImageRendering)
Declaration.hack(hackBackdropFilter)
Declaration.hack(hackBackgroundClip)
Declaration.hack(hackTextDecoration)
Declaration.hack(hackJustifyContent)
Declaration.hack(hackBackgroundSize)
Declaration.hack(hackGridRowColumn)
Expand Down
3 changes: 3 additions & 0 deletions test/autoprefixer.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,8 +1139,11 @@ test('add prefix for backface-visibility for Safari 9', () => {

test('supports text-decoration', () => {
let input = read('text-decoration')
let output = read('text-decoration.out')
let instance = prefixer('text-decoration')
let result = postcss([instance]).process(input)

equal(universalizer(result.css), universalizer(output))
equal(
result.warnings().map(i => i.toString()),
[
Expand Down
8 changes: 6 additions & 2 deletions test/cases/text-decoration.out.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,15 @@
}

.old {
text-decoration: underline;
-webkit-text-decoration: underline;
-moz-text-decoration: underline;
text-decoration: underline;
}

.global {
text-decoration: unset;
-webkit-text-decoration: unset;
-moz-text-decoration: unset;
text-decoration: unset;
}

.skip {
Expand Down