Skip to content

Fix: Ignore calc-size from detection #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Fix: Ignore calc-size from detection #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1126816
Add failing test
Antonio-Laguna Jan 5, 2025
8539f7a
Ensure Regex ignores calc-size
Antonio-Laguna Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/transform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const { parser } = require('../parser.js');
const reducer = require('./reducer.js');
const stringifier = require('./stringifier.js');

const MATCH_CALC = /((?:-(moz|webkit)-)?calc)/i;
const MATCH_CALC = /((?:-(moz|webkit)-)?calc(?!-))/i;

/**
* @param {string} value
Expand Down
17 changes: 17 additions & 0 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,18 @@ function testCss(fixture, expected, opts = {}) {
};
}

function testCssDoesNotThrow(fixture, expected, opts = {}) {
return async () => {
const result = await postcss(reduceCalc(opts)).process(
fixture,
postcssOpts
);
assert.strictEqual(result.css, expected);
const warnings = result.warnings();
assert.strictEqual(warnings.length, 0);
};
}

function testThrows(fixture, expected, warning, opts = {}) {
fixture = `foo{bar:${fixture}}`;
expected = `foo{bar:${expected}}`;
Expand Down Expand Up @@ -970,6 +982,11 @@ test(
testValue('calc(1px + 2unknown)', 'calc(1px + 2unknown)')
);

test(
'calc-size should be ignored',
testCssDoesNotThrow('.foo{block-size: calc-size(auto, size)}', '.foo{block-size: calc-size(auto, size)}')
);

test(
'error with parsing',
testThrows(
Expand Down
Loading