Rewrite of postcss-calc #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-eb
requested changes
Feb 2, 2017
src/lib/convert.es6
Outdated
| case 'ResolutionValue': | ||
| return convertAbsoluteLength(left, right, precision); | ||
| default: | ||
| return { |
There was a problem hiding this comment.
return {left, right}; might be a bit nicer. 😄
package.json
Outdated
| "main": "index.js", | ||
| "scripts": { | ||
| "test": "eslint src/**/*.es6 && npm run build && node tests/test.js", | ||
| "build": "babel src -d . && jison parser.jison" |
There was a problem hiding this comment.
This should be aprepublish script so that it is run before publishing to npm.
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "postcss-calc", | |||
| "version": "5.3.1", | |||
| "version": "6.0.0", | |||
There was a problem hiding this comment.
Can you remove the version bump from here please? https://github.com/sindresorhus/np takes care of this. 😄
Disable rounding when precision is false.
ben-eb
approved these changes
Feb 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrite is done with the intent of fixing inconsistent behaviour between postcss-calc and the W3C specification, as well as enabling better optimisation of
calc()expressions. The rewrite is done from the ground-up in ES6 while still staying compatible with the existing API. It reducescalc()functions by transforming ASTs generated from the expressions.The rewrite also solves the following issues:
calcon the name #35