Skip to content

use PostCSS 4.1 API #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2015
Merged

use PostCSS 4.1 API #10

merged 1 commit into from
Jun 13, 2015

Conversation

TrySound
Copy link
Member

fix #8

MoOx
MoOx reviewed Jun 13, 2015
View reviewed changes
.gitignore
@@ -1,2 +1,3 @@
node_modules
test/fixtures/*.actual.css
npm-debug.log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be in your global gitignore

@TrySound
Copy link
Member Author

Also I got an error
https://gist.github.com/TrySound/8f0b6dbdfe34731f1b17
Could it be postcss-message-helpers problem?

@MoOx
Copy link
Contributor

MoOx commented Jun 13, 2015

https://github.com/ianstormtaylor/css-color-function/blob/7d60b7171b45c723883aa5856b64bbe2a7bb0b1f/lib/convert.js#L44

@TrySound
Copy link
Member Author

@MoOx This error interrupted watcher.

@TrySound
Copy link
Member Author

@MoOx Is it gulp-postcss or postcss problem?

TrySound added a commit that referenced this pull request Jun 13, 2015
@TrySound
Merge pull request #10 from postcss/fix-plugin-api
7b8a5e5 
use PostCSS 4.1 API
@TrySound TrySound merged commit 7b8a5e5 into master Jun 13, 2015
@MoOx
Copy link
Contributor

MoOx commented Jun 13, 2015

Why did you merge this ? Since when you maintain this package ?
You should ask. There is not point to merge this if this is not published. You can use your fork until this is merged and published.

@TrySound
Copy link
Member Author

Sorry. I will not do it again.

@MoOx MoOx deleted the fix-plugin-api branch June 15, 2015 07:39
@MoOx
Copy link
Contributor

MoOx commented Jun 15, 2015

Also, you tagged a wrong version that doesn't have package.json up to date with the tag. 😠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use PostCSS 4.1 API
2 participants
@TrySound @MoOx