This repository was archived by the owner on Feb 18, 2022. It is now read-only.
Fix type definitions #257
Merged
Fix type definitions #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type definitions have slightly invalid syntax.
{ root: any } should be { root }: { root: any }
|
@Semigradsky could this get a patch release soon? |
|
Could we get a patch release with this fix ? |
romainmenke
pushed a commit
to csstools/postcss-plugins
that referenced
this pull request
Dec 15, 2021
The type definitions have slightly invalid syntax.
{ root: any } should be { root }: { root: any }
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I found that
postcss-custom-propertiesv12 was showing an error in my Typescript project recently (Automattic/wp-calypso#56600)This is because
prepare({ root: any })means to destructurerootand then assign it to the variableany. (An easy mistake to make; I remember doing the same thing a while ago!) It should beprepare( { root }: Type ), which translates toprepare( { root }: { root: any } ). We could also split the latter part out into its own type definition, but this gets the job done.To test this, I copied original file to the TS playground, and it has an error (link to playground). The new version does not have an error (link to playground).
Thanks for taking a look! cc @jonathantneal, any chance this could make a quick patch release?