-
Notifications
You must be signed in to change notification settings - Fork 8
Fix critical vulnerability CWE-78 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I repeat:
|
@RyanZim Repeat noted. If that provides the same solution and doesn't cause any issues, I'm with you. I was under the impression that the unique lib was being used to reduce the chance of two random strings ending up being the same. But you may very well be right, |
We're talking about giving each plugin an id; most plugin chains aren't crazy long, I don't think the uniqueness will be an issue. |
@RyanZim Yeah, that makes sense. |
Also, should have mentioned this the first time; please remove |
@RyanZim I've made those changes. |
Thanks! |
Feel free to add yourself here if you'd like: https://github.com/postcss/postcss-filter-plugins#contributors |
Will do 👍 |
Removed vulnerable dependancy (uniquid)
I have simply fixed the linting errors in the PR raised by @Narvey
#18