Fix bug where font-variant-caps: small-caps resulted in c2sc feature #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are failed tests |
|
Oops, my mistake. Tests are green now. |
|
Thank you! |
|
Glad I could help! It’s nice to see such a quick response. |
jonathantneal
pushed a commit
to csstools/postcss-preset-env
that referenced
this pull request
Oct 27, 2021
* Updating as per plugin spec See postcss/postcss-font-variant#15 * Adding all property back * Updating System UI plugin to be compatible with PostCSS 8 * Removing no longer existing property * Autoprefixer false doesn't mess with the rest of the file * Updating with up to spec from image set plugin * Using last mod since color-mod was rejected and no longer within pack * Updating main file to be up to PostCSS 8
romainmenke
pushed a commit
to csstools/postcss-plugins
that referenced
this pull request
Nov 16, 2021
* Updating as per plugin spec See postcss/postcss-font-variant#15 * Adding all property back * Updating System UI plugin to be compatible with PostCSS 8 * Removing no longer existing property * Autoprefixer false doesn't mess with the rest of the file * Updating with up to spec from image set plugin * Using last mod since color-mod was rejected and no longer within pack * Updating main file to be up to PostCSS 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #14. I’ve never written a non-trivial amount of Javascript, and don’t have a Javascript environment on my machine – I just
grepped forc2scand fixed it as best as I could. Please tell me if I’ve made any mistakes!