Skip to content

Conversation

@TrySound
Copy link
Member

No description provided.

@TrySound TrySound force-pushed the remove-with-api branch 3 times, most recently from f9244cb to 1d5d99b Compare December 14, 2015 20:28
@MoOx
Copy link
Contributor

MoOx commented Dec 15, 2015

It doesn't make sense to have to edit the expected result... Here postcss is still broken....

@MoOx
Copy link
Contributor

MoOx commented Dec 15, 2015

I don't think the codebase is complicated because of this trick that is required to keep a code as it is expected.

@TrySound
Copy link
Member Author

@MoOx This stuff just complicates code. And your tricks not always do what are expected. For example here

Selectors are expected to be indented

@media screen{
    foo{}
}

but we have some flat uncomfortable code.

Yes, maybe normalize do not do everything what you expect, but it do good work which shouldn't do plugins.

Let's simplify codebase with minimal changes in expected code and everything will be okay. :)

@MoOx
Copy link
Contributor

MoOx commented Dec 15, 2015

Previously I did that because normalize was bringing bugs
If you can confirm that postcss have fixed those issues then we might try...

MoOx added a commit that referenced this pull request Dec 15, 2015
@MoOx MoOx merged commit 13ac4e5 into master Dec 15, 2015
@MoOx MoOx deleted the remove-with-api branch December 15, 2015 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants