Remove promise-each dependency #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonathantneal
commented
May 6, 2017
- Resolves TypeError: Promise.resolve is not a function #275
- Removes any-promise subdependency
- Removes runtime assert from promise-each
RyanZim
approved these changes
May 6, 2017
| stmt.media = joinMedia(media, stmt.media || []) | ||
| return Promise.resolve(statements).then(function(stmts) { | ||
| return stmts.reduce(function(promise, stmt) { | ||
| return promise.then(function() { |
There was a problem hiding this comment.
LGTM, but perhaps we should have a comment here to explain that this cleverness works on the array in series.
There was a problem hiding this comment.
I’ll add a comment. I’m actually glad to see the reduce and then terminology used here instead of each, because each did not make me aware that this was processing the statements in “synchronous” sequence.
- Resolves #275 - Removes any-promise subdependency - Removes runtime assert from promise-each
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.