-
-
Notifications
You must be signed in to change notification settings - Fork 66
Improve @at-root
behavior
#147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
34ead38
tests: Normalize expected and actual strings to reduce noise
maranomynet 87d30eb
style: Add @ts-check and JSDoc type definitions to surface errors
maranomynet f848d45
tests: Add more passing tests
maranomynet 0832195
tests: Add failing tests for valid uses of `@at-root`
maranomynet 8004a96
style: Rename functions and variables for clarity
maranomynet 8d55747
rafactor: Resolve non-critical/false-positive type-checking issues
maranomynet c7a73d6
fix: Logic/typing error when handling @at-root rules
maranomynet 800d131
refactor: Simplify existing logic
maranomynet e427a6d
fix: Move all preceeding comments with rule
maranomynet 16c7282
fix: `@layer` blocks should also bubble
maranomynet 37c75f9
fix: Correctly handle `with`/`without` parameters on `@at-root`
maranomynet 3561b2e
feat: Add option `rootRuleName` to rename the custom `@at-root` rule
maranomynet 59d784e
style: Auto formatting/linting
maranomynet d085b71
fix: Remove hasRootRule optimization
maranomynet 99823d2
fix: Add back hasRootRule optimization, scoped to root node
maranomynet de5fbfc
docs: Update README
maranomynet 46829dc
style: Reformat test input
maranomynet 57655e3
tests: Add more `@at-rule` test, some failing
maranomynet 0b16af0
fix: Failing `@at-root` edge cases
maranomynet 4789f12
style: Fix typo in function name, remove console.log
maranomynet cb127a3
refactor: Remove @ts-check hack code path, use type assertion instead
maranomynet 738c417
test: Remove comments
maranomynet 91448d3
refactor: Use root#walkAtRules
maranomynet fcbb368
chore: Tweak eslint rule value
maranomynet ce88aac
refactor: Fix linting errors …
maranomynet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.