Skip to content

fix order of rules #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2017
Merged

fix order of rules #52

merged 2 commits into from
May 8, 2017

Conversation

Riim
Copy link
Contributor

@Riim Riim commented May 8, 2017

Исправление для сломавшегося порядка следования правил.

@ai
Copy link
Member

ai commented May 8, 2017

Can you add a test for this fix (I am not sure what order do you try to fix).

@ai ai merged commit 7f67183 into postcss:master May 8, 2017
@ai
Copy link
Member

ai commented May 8, 2017

Released in 2.0.1

@ai
Copy link
Member

ai commented May 8, 2017

Thanks :)

@skipjack
Copy link

@ai still seeing this issue, can you see my configuration in webpack-contrib/postcss-loader#210 to see if anything is off? I can't tell if the issue is this plugin or the loader...

@ai
Copy link
Member

ai commented May 11, 2017

Can you describe you exactly problem here? Input CSS, output, expected output?

(Today is hard day for me, so I need you help)

@skipjack
Copy link

Yeah, no worries. I'm actually going to put together a minimal test case for this in the issue I linked to above so I'll cc you once I have that ready.

@skipjack
Copy link

@ai see the demo I just put up.

@ai
Copy link
Member

ai commented May 11, 2017

Thanks, I will look tomorrow.

@ai
Copy link
Member

ai commented May 12, 2017

@skipjack I tested with latest postcss-nested and output was:

body {
	margin: 0;
}

.test {
	display: flex;
	font-size: 3em;
	height: 100vh;
	justify-content: center;
	align-items: center;
	color: black;
	background: grey;
}

.test--white {
		color: white;
	}

.test--blue {
		color: blue;
	}

Very strange that we have different behaviour in your demo.

@skipjack
Copy link

Ah thanks for testing... it actually turned out to be postcss-cssnext, sorry for bugging you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants