TS2310: Type 'Selector' recursively references itself as a base type.

[ybiquitous]

Hello, I encounter the following TypeScript error with the version 6.0.3.

Here is the reproduction via Docker:

FROM node:14
WORKDIR /work
RUN git clone --depth=1 https://github.com/postcss/postcss-selector-parser.git /work
RUN npm i typescript@4.0.3
ENTRYPOINT ["npx", "tsc", "postcss-selector-parser.d.ts"]

Put Dockerfile with the content above to any directory and then run the following command:

$ docker build -t postcss-selector-parser:dev .
...

$ docker run --rm -it postcss-selector-parser:dev
postcss-selector-parser.d.ts:335:15 - error TS2310: Type 'Selector' recursively references itself as a base type.

335     interface Selector extends Container<string, Diff<Node, Selector>> {
                  ~~~~~~~~


Found 1 error.

The location:

postcss-selector-parser/postcss-selector-parser.d.ts

Lines 335 to 337 in 1682f72

	interface Selector extends Container<string, Diff<Node, Selector>> {
	type: "selector";
	}

See also the real-world reproduction: stylelint/stylelint#4949

[alexander-akait]

Feel free to send a fix, don't have time on this right now, sorry

[ybiquitous]

I'm looking into a solution, but I cannot find it yet... 😕

[ybiquitous]

I'm not sure whether this solution is right, but I could find it:

diff --git a/postcss-selector-parser.d.ts b/postcss-selector-parser.d.ts
index 1fc4fba..383e222 100644
--- a/postcss-selector-parser.d.ts
+++ b/postcss-selector-parser.d.ts
@@ -332,9 +332,10 @@ declare namespace parser {
     function root(opts: ContainerOptions): Root;
     function isRoot(node: any): node is Root;
 
-    interface Selector extends Container<string, Diff<Node, Selector>> {
+    interface _Selector<S> extends Container<string, Diff<Node, S>> {
         type: "selector";
     }
+    type Selector = _Selector<Selector>;
     function selector(opts: ContainerOptions): Selector;
     function isSelector(node: any): node is Selector;
 

See also microsoft/TypeScript#33050

[ybiquitous]

Note that this error occurs on TypeScript 4, not TypeScript 3:

diff --git a/Dockerfile b/Dockerfile
index 2a89618..91f5acd 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,5 +1,5 @@
 FROM node:14
 WORKDIR /work
 RUN git clone --depth=1 https://github.com/postcss/postcss-selector-parser.git /work
-RUN npm i typescript@4.0.3
+RUN npm i typescript@3.9.7
 ENTRYPOINT ["npx", "tsc", "postcss-selector-parser.d.ts"]

$ docker build -t postcss-selector-parser:dev
...

$ docker run --rm -it postcss-selector-parser:dev
(no output)

[ybiquitous]

@evilebottnawi Thanks! I'll try the new version 6.0.4 on stylelint repo.