fix: fix parsing of attributes that contain newline character #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feel free to send a fix, should be easy |
|
Here place to fix https://github.com/postcss/postcss-selector-parser/blob/master/src/selectors/attribute.js (I think) |
Also match new lines in the regex that checks for quoted attributes.
Seems changing a regex was all that was needed. |
| t.deepEqual(tree.nodes[0].nodes[0].operator, '='); | ||
| t.deepEqual(tree.nodes[0].nodes[0].value, 'woop \nwoop woop'); | ||
| t.true(tree.nodes[0].nodes[0].quoted); | ||
| }); |
There was a problem hiding this comment.
Let's add other popular example:
// http://jsfiddle.net/BoltClock/AHuvh/6
a[href="\a http://google.com"] {
}Just avoid future regressions. Anyway good job!
There was a problem hiding this comment.
Unfortunately this example fails at the moment. It turns into \a into a (removes only the \). It seems a different problem though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think css-selector-parser fails to correctly parse attribute selectors that contain new lines, as it believes the quotes are part of the value. This makes it hard to port
postcss-minify-selectorsto thecss-selector-parser6.0.