Skip to content

Conversation

@vdepizzol
Copy link
Contributor

⚠️ this is a draft PR

This draft includes some considerations for adding support to different UI scales in Primer. Discussion is still happening on https://github.com/github/design-systems/issues/969.

For now this only creates a ui-scale mixin that can be consumed by components that need specialized styles on touch-based devices. It uses pointer: fine/coarse from Media Queries Level 4.

Application example

.dropdown-item {
  display: block;
  padding: $spacer-1 $spacer-3;
  // (...)
  
  @include ui-scale(large) {
    padding-top: $spacer-2;
    padding-bottom: $spacer-2;
  }
}
  • Fixes github/design-systems/issues/969

@vercel
Copy link

vercel bot commented Aug 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-css/5u5fsg4i8
✅ Preview: https://primer-css-git-ui-scale.primer.vercel.app

@vdepizzol vdepizzol requested a review from adrianmg October 13, 2020 22:12
@vdepizzol vdepizzol requested review from adrianmg and removed request for adrianmg October 14, 2020 06:25
Base automatically changed from master to main March 26, 2021 00:50
@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2021

⚠️ No Changeset found

Latest commit: 80b8974

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale Automatically marked as stale. label Jun 26, 2021
@github-actions github-actions bot closed this Jul 3, 2021
@github-actions github-actions bot deleted the ui-scale branch July 3, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants