Skip to content

[Proposal] Remove carets from all components with built in carets #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[Proposal] Remove carets from all components with built in carets #1191

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a3ba61
Removes carets from all components with built in carets
Nov 5, 2020
bb4f30c
delete support/mixins/misc.scss file
Nov 6, 2020
8a5d99e
remove import reference for misc.scss
Nov 6, 2020
f7fe77d
update warning label colors
Nov 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Removes carets from all components with built in carets
  • Loading branch information
Colin committed Nov 5, 2020
commit 2a3ba614cb31c056be7deff7dbeeb5fe6ec7d7e9
159 changes: 0 additions & 159 deletions src/dropdown/dropdown.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,25 +35,6 @@
border-radius: $border-radius;
box-shadow: $box-shadow-large;

&::before,
&::after {
position: absolute;
display: inline-block;
content: "";
}

&::before {
// stylelint-disable-next-line primer/borders
border: $spacer-2 $border-style transparent;
border-bottom-color: $border-black-fade;
}

&::after {
// stylelint-disable-next-line primer/borders
border: 7px $border-style transparent;
border-bottom-color: $border-white;
}

// stylelint-disable-next-line selector-max-type
> ul {
list-style: none;
Expand Down Expand Up @@ -134,22 +115,6 @@
width: auto;
margin-top: 0;
margin-right: $spacer-2;

&::before {
top: 10px;
right: -$spacer-3;
left: auto;
border-color: transparent;
border-left-color: $border-black-fade;
}

&::after {
top: 11px;
right: -14px;
left: auto;
border-color: transparent;
border-left-color: $border-white;
}
}

.dropdown-menu-e {
Expand All @@ -158,20 +123,6 @@
width: auto;
margin-top: 0;
margin-left: $spacer-2;

&::before {
top: $spacer-2;
left: -$spacer-3;
border-color: transparent;
border-right-color: $border-black-fade;
}

&::after {
top: 11px;
left: -14px;
border-color: transparent;
border-right-color: $border-white;
}
}

.dropdown-menu-ne {
Expand All @@ -180,83 +131,17 @@
left: 0;
// stylelint-disable-next-line primer/spacing
margin-bottom: 3px;

&::before,
&::after {
top: auto;
right: auto;
}

&::before {
bottom: -$spacer-2;
left: 9px;
// stylelint-disable-next-line primer/borders
border-top: $spacer-2 $border-style $border-black-fade;
// stylelint-disable-next-line primer/borders
border-right: $spacer-2 $border-style transparent;
border-bottom: 0;
// stylelint-disable-next-line primer/borders
border-left: $spacer-2 $border-style transparent;
}

&::after {
bottom: -7px;
left: 10px;
// stylelint-disable-next-line primer/borders
border-top: 7px $border-style $border-white;
// stylelint-disable-next-line primer/borders
border-right: 7px $border-style transparent;
border-bottom: 0;
// stylelint-disable-next-line primer/borders
border-left: 7px $border-style transparent;
}
}

.dropdown-menu-s {
right: 50%;
left: auto;
transform: translateX(50%);

&::before {
top: -$spacer-3;
right: 50%;
transform: translateX(50%);
}

&::after {
top: -14px;
right: 50%;
transform: translateX(50%);
}
}

.dropdown-menu-sw {
right: 0;
left: auto;

&::before {
top: -$spacer-3;
right: 9px;
left: auto;
}

&::after {
top: -14px;
right: 10px;
left: auto;
}
}

.dropdown-menu-se {
&::before {
top: -$spacer-3;
left: 9px;
}

&::after {
top: -14px;
left: 10px;
}
}

// Dark dropdowns
Expand All @@ -267,15 +152,6 @@
border-color: $border-gray-darker;
box-shadow: $box-shadow-large;

&::before {
border-bottom-color: $border-gray-darker;
}

&::after {
// stylelint-disable-next-line primer/borders
border-bottom-color: $gray-800;
}

.dropdown-header {
// stylelint-disable-next-line primer/colors
color: $gray-300;
Expand All @@ -288,39 +164,4 @@
.dropdown-item {
color: inherit;
}

// Directional classes

&.dropdown-menu-w {
&::before {
border-color: transparent transparent transparent $border-gray-darker;
}

&::after {
// stylelint-disable-next-line primer/borders
border-color: transparent transparent transparent $gray-800;
}
}

&.dropdown-menu-e {
&::before {
border-color: transparent $border-gray-darker transparent transparent;
}

&::after {
// stylelint-disable-next-line primer/borders
border-color: transparent $gray-800 transparent transparent;
}
}

&.dropdown-menu-ne {
&::before {
border-color: $border-gray-darker transparent transparent transparent;
}

&::after {
// stylelint-disable-next-line primer/borders
border-color: $gray-800 transparent transparent transparent;
}
}
}
156 changes: 0 additions & 156 deletions src/popover/popover.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,176 +8,20 @@
width: 232px;
margin-right: auto;
margin-left: auto;

// Carets
&::before,
&::after {
position: absolute;
left: 50%;
display: inline-block;
content: "";
}

&::before {
top: -$spacer-3;
// stylelint-disable-next-line primer/spacing
margin-left: -9px;
// stylelint-disable-next-line primer/borders
border: $spacer-2 $border-style transparent;
border-bottom-color: $border-black-fade;
}

&::after {
top: -14px;
margin-left: -$spacer-2;
// stylelint-disable-next-line primer/borders
border: 7px $border-style transparent;
// stylelint-disable-next-line primer/borders
border-bottom-color: $bg-white;
}
}

// Bottom-oriented carets
.Popover-message--bottom,
.Popover-message--bottom-right,
.Popover-message--bottom-left {
&::before,
&::after {
top: auto;
border-bottom-color: transparent;
}

&::before {
bottom: -$spacer-3;
border-top-color: $border-black-fade;
}

&::after {
bottom: -14px;
// stylelint-disable-next-line primer/borders
border-top-color: $bg-white;
}
}

// Top & Bottom: Right-oriented carets
.Popover-message--top-right,
.Popover-message--bottom-right {
right: -9px;
margin-right: 0;

&::before,
&::after {
left: auto;
margin-left: 0;
}

&::before {
right: 20px;
}

&::after {
right: 21px;
}
}

// Top & Bottom: Left-oriented carets
.Popover-message--top-left,
.Popover-message--bottom-left {
left: -9px;
margin-left: 0;

&::before,
&::after {
left: $spacer-4;
margin-left: 0;
}

&::after {
left: $spacer-4 + 1;
}
}

// Right- & Left-oriented carets
.Popover-message--right,
.Popover-message--right-top,
.Popover-message--right-bottom,
.Popover-message--left,
.Popover-message--left-top,
.Popover-message--left-bottom {
&::before,
&::after {
top: 50%;
left: auto;
margin-left: 0;
border-bottom-color: transparent;
}

&::before {
// stylelint-disable-next-line primer/spacing
margin-top: -($spacer-2 + 1);
}

&::after {
margin-top: -$spacer-2;
}
}

// Right-oriented carets
.Popover-message--right,
.Popover-message--right-top,
.Popover-message--right-bottom {
&::before {
right: -$spacer-3;
border-left-color: $border-black-fade;
}

&::after {
right: -14px;
// stylelint-disable-next-line primer/borders
border-left-color: $bg-white;
}
}

// Left-oriented carets
.Popover-message--left,
.Popover-message--left-top,
.Popover-message--left-bottom {
&::before {
left: -$spacer-3;
border-right-color: $border-black-fade;
}

&::after {
left: -14px;
// stylelint-disable-next-line primer/borders
border-right-color: $bg-white;
}
}

// Right & Left: Top-oriented carets
.Popover-message--right-top,
.Popover-message--left-top {
&::before,
&::after {
top: $spacer-4;
}
}

// Right & Left: Bottom-oriented carets
.Popover-message--right-bottom,
.Popover-message--left-bottom {
&::before,
&::after {
top: auto;
}

&::before {
bottom: $spacer-3;
}

&::after {
bottom: $spacer-3 + 1;
}
}

.Popover-message--large {
Expand Down
Loading