Change #666 to #767676 #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This achieves minimum AA compliancy against `#fff` with a change that's less stark than the current `#666`. For `color`s against `#eee` though, we'll need to manually adjust the values, but I think that's fair game.
`#666` meets AA while the updated `#767676` doesn't against `#eee`
tv104
pushed a commit
to tv104/primer
that referenced
this pull request
Aug 12, 2015
Pulling in the scss-lint rules from .com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This achieves minimum AA compliancy against
#fffwith a change that's less stark than the current#666. Forcolors against#eeethough, we'll need to manually adjust the values, but I think that's fair game. It's a slightly different approach, but one that maintains a bit more of the site's feel.