-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Deploying the primer.style website with a github action instead of vercel-bot #1303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| with: | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| vercel-token: ${{ secrets.VERCEL_TOKEN_SHARED }} | ||
| github-comment: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we don't want vercel to make a github comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it was extra noise we didn't really need since there's deployment statuses in the PR also. but that's my personal preference, I'm open to others thoughts. We also have the option to put custom content in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM. Let's try it out and see if it works 🤞
|
🤞🏻 |
closes #1301
This PR disables the
vercel-botauto deployment and uses this vercel action instead https://github.com/marketplace/actions/vercel-actionThe reasoning behind this is more control on when we deploy. Here's the new logic:
mainand touchessrc/**, docs/**, package.jsonfiles. This helps cleans up the auto deploys on PRs and only deploys when the pr changes something that effects the output of the site.mainbranch and touchessrc/**, docs/**, package.jsonfiles. The workflow also checks the changesets to see if this is a new version release or if there's a release being worked on. When there's currently a release being worked on and hasn't been published yet, the script doesn't deploy.