Primer 3 #151
Merged
Primer 3 #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also tighten up line-height
…of those everywhere
…use of non-markdown bodies of text elsewhere
- Remove the element and attribute selectors to reduce specificity elsewhere - Use a singular class for all text inputs, textareas, and selects (.form-control) - Update modifier classes to use .input-* - More consisitent modifier classes now available (no more element prefixes in selectors, .input-mini is now .input-sm, .input-large is now .input-lg) - Port some additional styling to custom .select controls since we're not longer styling the default select element with the move to a class
- Break apart buttons and forms files a bit for granularity - Move entire utility file to the end of the import stack (should always be there for specificity reasons)
scss/_input-group.scss
Outdated
There was a problem hiding this comment.
Merge rule .form-control + .btn with rule on line 4
This was referenced Sep 11, 2015
Closed
scss/_utility.scss
Outdated
There was a problem hiding this comment.
Colon after property should be followed by one space
scss/_form-group.scss
Outdated
| } | ||
|
|
||
| &.warn { | ||
| dd.warning { |
There was a problem hiding this comment.
Avoid qualifying class selectors with an element.
|
This pull feels like it's in a pretty good place now. Here's what I want to do. Merge it into master, (but not tag the new version yet) I need to create a pull on github/github https://github.com/github/github/pull/51212 that pulls in the master branch here and uses it to make updates to the .com codebase. When I get everything fixed and shipped there. I'll come back and tag the new version 3.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a heavily WIP effort to rewrite large chunks of Primer as part of a major update.
Summary
The goal here is to rewrite several components for simpler styling, reduce specificity of selectors, reduce overrides elsewhere in GitHub's CSS, and more.
Changelog
margin-topandmargin-bottomoverrides ingithub/github. (This won't affect our Markdown styles as those are scoped under a parent class and override this all.)Todo
Additional changes still to be determined.
/cc @jonrohan @josh @aroben