Using stylelint to replace deprecated variables in primer/css #1562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1285a4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simurai
requested changes
Aug 31, 2021
There was a problem hiding this comment.
I think --color-bg-overlay should map to --color-canvas-overlay instead of --color-primer-canvas-backdrop? 🤔
That's happening here, https://github.com/primer/primitives/blob/main/data/colors_v2/deprecations.json#L34 might be good to audit this before we ship everything. cc @colebemis |
|
Going to re-run this in a new pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces all of the deprecated variables using the new stylelint plugin https://github.com/primer/stylelint-config-primer/blob/main/plugins/no-deprecated-colors.js
We should ship this with the next major version.
Stats
This replaces
173CSS variables from v1, with37variables from v2! 📉