Skip to content

Upgrading @primer/stylelint-config@12.3.3 #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 28, 2022
Merged

Upgrading @primer/stylelint-config@12.3.3 #1956

merged 5 commits into from
Feb 28, 2022

Conversation

@jonrohan
Copy link
Member

@jonrohan jonrohan commented Feb 27, 2022 •
edited
Loading

What are you trying to accomplish?

This upgrades @primer/stylelint-config to 12.3.2 and 12.3.3 which have some improvements to the spacing plugin to check functional groups.

What approach did you choose and why?

yarn add @primer/stylelint-config@latest
yarn stylelint:fix
yarn stylelint:add-disables

Are additional changes needed?

  • No, this PR should be ok to ship as is. 🚢

@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 2bdae2f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan changed the title Upgrading @primer/stylelint-config@12.3.2 Upgrading @primer/stylelint-config@12.3.3 Feb 28, 2022
@jonrohan jonrohan marked this pull request as ready for review February 28, 2022 20:57
@jonrohan jonrohan requested a review from a team as a code owner February 28, 2022 20:57
@jonrohan jonrohan requested a review from simurai February 28, 2022 20:57
@jonrohan jonrohan enabled auto-merge (squash) February 28, 2022 20:57
langermank
langermank reviewed Feb 28, 2022
View reviewed changes
src/actionlist/action-list-item-divider.scss
display: block;
height: 1px;
padding: 0;
// stylelint-disable-next-line primer/spacing
Copy link
Contributor

@langermank langermank Feb 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃

@jonrohan jonrohan merged commit 3906346 into main Feb 28, 2022
@jonrohan jonrohan deleted the upgrade-stylelint-config branch February 28, 2022 22:35
@primer-css primer-css mentioned this pull request Feb 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@langermank langermank langermank approved these changes

@simurai simurai Awaiting requested review from simurai simurai was automatically assigned from primer/css-reviewers

Assignees

No one assigned

Labels

patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonrohan @langermank