Skip to content

Conversation

@simurai
Copy link
Contributor

@simurai simurai commented Apr 4, 2022

What are you trying to accomplish?

Currently when making a PR we ask this question:

Are additional changes needed?

When is then answered with a "no":

[x] No, this PR should be ok to ship as is.

Having to check a "No" answer might be confusing.

What approach did you choose and why?

So this PR changes the question so it can be answered with "Yes".

What should reviewers focus on?

Any better wording?

Are additional changes needed?

  • No, this PR should be ok to ship as is. 🚢

@simurai simurai requested a review from a team as a code owner April 4, 2022 02:59
@simurai simurai requested a review from langermank April 4, 2022 02:59
@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2022

⚠️ No Changeset found

Latest commit: 5acc455

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@simurai simurai changed the title Update dependency question Update pull_request_template Apr 4, 2022
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@simurai simurai merged commit d979039 into main Apr 8, 2022
@simurai simurai deleted the update-pull_request_template branch April 8, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants