Fieldset disable

[mlynam]

What are you trying to accomplish?

The fieldset can be used to disable all child inputs when it is disabled. Currently, @primer/css does not render .form-control as disabled when a parent fieldset is disabled. This PR supports the visual feedback on .form-control when a parent fieldset is disabled.

What approach did you choose and why?

I used a local mixin in form-control.scss to keep the codebase dry and to ensure the disabled style was consistent when applied via .form-control:disabled or fieldset:disabled .form-control

What should reviewers focus on?

Reviewers should ensure my local mixin approach is appropriate for readability and code-style.

I noted that the Storybook instance overrides the fieldset styling (from normalize.css) found in form-control.scss and I was unsure what the approach should be to ensure only the @primer/css styling wins. I did not want to apply !important specificity as there would be drawbacks to that approach.

Can these changes ship as is? Yes

• Yes, this PR does not depend on additional changes. 🚢

[changeset-bot]

🦋 Changeset detected

Latest commit: 5f10b78

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/css	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[mlynam]

Is there anything I can do to improve this PR and get it shipped?

[simurai]

This looks good to me.. @mlynam thanks. 🙇