Fix select mask #2128
Closed
Fix select mask #2128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: acca0bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
langermank
requested changes
Jun 19, 2022
There was a problem hiding this comment.
Interesting! We use autoprefixer for stuff like this, and I just double checked to see if this one got a prefix. You can search for it here.
We should consider how to handle this kind of thing for tools like Storybook and Lookbook.. we prefer to use source CSS, but dist contains extra stuff we're not exactly testing 🤔
|
@langermank hmm ok interesting! Let me see if I can run autoprefixer automatically somehow. |
|
Closing in favor of primer/rails_forms@e562dfc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
The new
.FormControlstyles work nicely, but the SVG mask used for select lists appears as a gray box in Webkit browsers like Chrome:What approach did you choose and why?
According to caniuse,
mask-*properties are only supported via the-webkit-vendor prefix. Adding the prefix appears to fix the problem:What should reviewers focus on?
I had to tell stylelint to ignore the
-webkit-prefix here, which feels dirty but I don't think there's another way.Can these changes ship as is?