479-user-pics-misaligned-in-issues-assignment-view #2242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8718373 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Not last child means that each stacking avatar would remove the border-right which is necessary to stack correctly. The presentational order is right to left not left to right.
- Fixed pointer to the anchor element
jonrohan
approved these changes
Sep 7, 2022
- removed branch name from changeset Co-authored-by: Jon Rohan <yes@jonrohan.codes>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Looking to fix the user pics misalignment issue found in the assignments view.
Issue found here.
Now it should look like this
What approach did you choose and why?
I am following the approach provided in the issue before testing the new canary in dotcom
What should reviewers focus on?
The reviewer should focus on the spacing of the user profile images in the assignment view.
Can these changes ship as is?