Skip to content

Add utilities to Storybook #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 30, 2023
Merged

Add utilities to Storybook #2370

merged 12 commits into from
Jan 30, 2023

Conversation

@simurai
Copy link
Contributor

@simurai simurai commented Jan 27, 2023 •
edited
Loading

What are you trying to accomplish?

This is part of primer/design#364 and adds the utilities to Storybook.

👀 Preview

What approach did you choose and why?

It will allow the utilities to be embedded in the new unified docs.

What should reviewers focus on?

There are some small improvements here and there but the migration is mostly kept as is.

Tasks

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: b47c599

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@simurai simurai mentioned this pull request Jan 27, 2023
Merged
7 tasks
@simurai simurai temporarily deployed to github-pages January 27, 2023 13:12 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview January 27, 2023 13:12 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview January 30, 2023 02:46 Inactive
@simurai simurai marked this pull request as ready for review January 30, 2023 05:40
@simurai simurai requested a review from a team as a code owner January 30, 2023 05:40
@simurai simurai merged commit a8a5d05 into main Jan 30, 2023
@simurai simurai deleted the add-utilities-storybook branch January 30, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukasoppermann lukasoppermann Awaiting requested review from lukasoppermann lukasoppermann was automatically assigned from primer/css-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simurai