Skip to content

Conversation

@lukasoppermann
Copy link
Contributor

What are you trying to accomplish?

Remove the DiffStat component

What approach did you choose and why?

Removed the code.

What should reviewers focus on?

Did I miss something?

Can these changes ship as is?

Warning
While this technically has no dependencies, we need to add diffStat to dotcom first, to not break something.

  • Yes, this PR does not depend on additional changes. 🚢

@lukasoppermann lukasoppermann requested a review from a team as a code owner March 27, 2023 07:15
@changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2023

🦋 Changeset detected

Latest commit: 95b315f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasoppermann lukasoppermann requested a review from simurai March 27, 2023 07:15
@lukasoppermann lukasoppermann self-assigned this Mar 27, 2023
@github-actions github-actions bot temporarily deployed to Storybook Preview March 27, 2023 07:22 Inactive
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukasoppermann lukasoppermann merged commit 256affc into main Mar 27, 2023
@lukasoppermann lukasoppermann deleted the rm-diffStat branch March 27, 2023 13:38
@primer-css primer-css mentioned this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants