Skip to content

Conversation

@jonrohan
Copy link
Member

I'm updating exact value matches for any padding, margin, left, right, top, bottom positioning to use our Sass variables spacing scale instead.

This is an easy first step to eventually using our spacing scale throughout the library. The next step will be tweaking any space sizes close to the variables.

Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eeeeexcellent.

Copy link
Contributor

@broccolini broccolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the $margin variable as part of this pr? Otherwise, LGTM :shipit:

@jonrohan jonrohan merged commit c807cd2 into dev Jul 24, 2017
@jonrohan jonrohan deleted the spacer_variables branch July 24, 2017 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants