provide css vars to ::backdrop #2519
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Attempting to use Primer's css variables in a
::backdropelement. This doesn't work because::backdropis like::selectionin that it does not inherit from:root. Consequently,::backdropneeds to be provided all the CSS vars.In addition,
::backdropis not supported by all browsers (Safari 14 does not support it), so we need to give it its own separate style rule so that it does not break the parsing of the:rootstyle rule when encountered.What approach did you choose and why?
I chose to add
::backdropas a second style rule in the@if $include-rootsection of thecolor-mode-themeblock.What should reviewers focus on?
Alternatives would be to not use
::backdrop, but that is far more complex.Can these changes ship as is?