Skip to content

Use tabular numbers in tables #2680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Use tabular numbers in tables #2680

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd7782e
Use tabular numbers in tables
robinwhittleton Aug 16, 2024
02bb222
Merge branch 'main' into table-tnums
langermank Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use tabular numbers in tables 
As tables are frequently used for comparing columns of numeric data (and have the ability to be right-aligned) we should make sure that we make it as easy as possibly. Toggling tabular numbers on givens you the ability to scan columns of numbers effectively, assuming the font supports it. If it doesn’t then this doesn’t have any effect, but is no worse than the current behaviour.
  • Loading branch information
@robinwhittleton
robinwhittleton committed Aug 16, 2024
commit fd7782e3ce68fb65fe558f5a74fd2e66e4e607b2
5 changes: 5 additions & 0 deletions .changeset/wise-ducks-beam.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/css': patch
---

Use tabular numbers in tables
1 change: 1 addition & 0 deletions src/markdown/tables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
width: max-content;
max-width: 100%;
overflow: auto;
font-variant: tabular-nums;

th {
font-weight: $font-weight-bold;
Expand Down