Add fill-inherit utility class #330
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonrohan
requested changes
Aug 29, 2017
There was a problem hiding this comment.
We already have this applied to all our octicons https://github.com/primer/octicons/blob/master/lib/octicons.css
|
🤦🏻♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
fill-inheritutility class that setsfill: currentColor, which is particularly useful for inline SVG that you want to "inherit" whatever CSScolorvalue its adjacent text has (including:hoverstyles).With this, you can avoid having to double up on classes like
text-blue fill-blueand usetext-blue fill-inheritinstead, and allow octicons to inherit the link color without having to explicitly specifyfill-blue, which saves us some refactoring later when links become purple.This probably can't be part of #329, since merging it will prompt a version bump from Lerna. So maybe we release 9.4 then queue this up for 9.5?
TODO
/cc @primer/design-systems