Skip to content

[WIP] tooltip component updates #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 63 commits into from
Closed

[WIP] tooltip component updates #362

Changes from 1 commit
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
4e60c70
add tooltip stories
broccolini Oct 7, 2017
8e6a3d1
move tooltip variables into tooltips module
broccolini Oct 7, 2017
863fb12
Make tooltips black and update white variable
broccolini Oct 7, 2017
43951a0
update padding and line-height so tooltip height lands on whole pixels
broccolini Oct 7, 2017
3275a6f
for some reason doesn't like the variable
broccolini Oct 7, 2017
6da680b
adjust tooltip caret size and margin so overlaps with tooltip body
broccolini Oct 7, 2017
a24f5ea
use variable for border-radius
broccolini Oct 7, 2017
48ca2f7
missed some variations, make them consistent
broccolini Oct 7, 2017
289095d
use spacer variables
broccolini Oct 7, 2017
5771ad3
add tooltip modifiers for align right and left
broccolini Oct 8, 2017
da39183
re-order stories
broccolini Oct 8, 2017
b24b873
add align modifiers to docs
broccolini Oct 8, 2017
484c911
re-order sass
broccolini Oct 8, 2017
2f1a72f
Copy CSS over from https://github.com/github/github/blob/8d6e8bcea9f4…
Oct 27, 2017
dbf4b84
Rename AvatarStack
Oct 27, 2017
20b3186
Remove container (for now). And Authors 1&2 css.
Oct 27, 2017
db3ef68
Add new AvatarStack to storybook
Oct 27, 2017
e003cd0
lint
Oct 27, 2017
f0393d7
Delete a lot of unnecessary (i think?) CSS
Oct 27, 2017
314b630
cleanup
Oct 27, 2017
ef42395
fix avatar-more styling
califa Oct 31, 2017
e942b6d
implement container and switch classes around
califa Oct 31, 2017
ac78db0
make avatar stacks position absolute, reduce margin
califa Oct 31, 2017
6af7e76
fix linter
califa Nov 1, 2017
bb5bd3b
add specific sizes for avatar count
califa Nov 1, 2017
b3d3ebb
update storybook
califa Nov 1, 2017
0f6465d
remove temp tooltip alignment css back to github/github
califa Nov 2, 2017
01b9f67
add em unit to padding
broccolini Nov 2, 2017
62bba0b
missed a border variable
broccolini Nov 2, 2017
ae7a475
Merge branch 'dev' into brocs/tooltips
broccolini Nov 2, 2017
e374740
add first version of non-working right aligned modifier
califa Nov 2, 2017
ff7967f
refactor right align modifier, update storybook
califa Nov 2, 2017
a03d4e6
modify spacing so it works with storybook
califa Nov 2, 2017
8cca4f5
white space workaround
califa Nov 2, 2017
9c57895
make ci happy
califa Nov 2, 2017
80fd1fa
flip padding
califa Nov 2, 2017
251036d
refactor css
califa Nov 2, 2017
a73abae
add margins to storybook
califa Nov 2, 2017
2fa1d34
replace inline-block with flexbox
califa Nov 2, 2017
ef0f1e5
re-add last child z-index
califa Nov 3, 2017
da3ae73
remove padding now that avatars have margins
califa Nov 3, 2017
6ab6594
remove unrequired css
califa Nov 3, 2017
8351eea
Merge branch 'release-10.0.0' into brocs/tooltips
broccolini Nov 4, 2017
9e9d9c1
first draft for new avatar stack docs
califa Nov 6, 2017
7e491e2
move position absolute into container class
broccolini Nov 7, 2017
03a3d75
replace people avatars with octocats in storybook
broccolini Nov 7, 2017
8b99d32
update modifier class names
broccolini Nov 7, 2017
4956549
fix length modifiers
califa Nov 9, 2017
c2a392f
replace employees with octocats, remove redundant alts
califa Nov 13, 2017
8a1074a
Merge branch 'dev' into avatar-stack
jonrohan Nov 13, 2017
9fec40d
Add AvatarStack-body to the readme file
califa Nov 13, 2017
29f2689
Merge branch 'avatar-stack' of github.com:primer/primer-css into avat…
califa Nov 13, 2017
ef4ac3e
Merge pull request #385 from primer/avatar-stack
broccolini Nov 14, 2017
37f657a
increase padding and put back to default lineheight
broccolini Nov 14, 2017
2145536
Merge branch 'release-10.1.0' into brocs/tooltips
broccolini Nov 14, 2017
d0d1e40
Merge branch 'dev' into release-10.1.0
broccolini Nov 14, 2017
f5ef7d3
Merge branch 'release-10.1.0' into brocs/tooltips
broccolini Nov 14, 2017
beb1a27
Merge branch 'dev' into brocs/tooltips
broccolini Nov 15, 2017
d3fcc40
Merge branch 'brocs/tooltips' of https://github.com/primer/primer int…
broccolini Nov 15, 2017
ec460a5
udpate readme with caret variations
broccolini Nov 15, 2017
e75a3bd
Revert "Merge branch 'release-10.1.0' into brocs/tooltips"
broccolini Nov 15, 2017
4b70835
Revert "Merge branch 'release-10.1.0' into brocs/tooltips"
broccolini Nov 15, 2017
1bd0fb1
Revert "udpate readme with caret variations"
broccolini Nov 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
implement container and switch classes around
  • Loading branch information
@califa
califa committed Oct 31, 2017
commit e942b6dc48582d331c4db566cce6d92a4703f6f3
8 changes: 7 additions & 1 deletion modules/primer-avatars/lib/avatar-stack.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,12 @@
// Refactored, new avatar stack:

.AvatarStack {
position: relative;
min-width: 26px;
height: 20px;
}

.AvatarStack-body {
background: inherit;

.avatar {
Expand Down Expand Up @@ -122,7 +128,7 @@
}
}

.AvatarStack:hover .avatar-more {
.AvatarStack-body:hover .avatar-more {
display: none;
}

Expand Down