Skip to content

Better release candidate logic #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 23, 2017
Merged

Better release candidate logic #370

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
99dc990
move generator-primer-module to /tools/
shawnbot Oct 10, 2017
bcf156c
a new suite of RC tools
shawnbot Oct 10, 2017
7413bcf
add commit status notifications
shawnbot Oct 12, 2017
2a44a63
really publish to npm
shawnbot Oct 12, 2017
0883140
pass env vars to script/notify
shawnbot Oct 12, 2017
db7474c
just put objects in the changed Set
shawnbot Oct 12, 2017
21d19f0
update compare-published to work w/multiple module dirs
shawnbot Oct 12, 2017
9fef0d2
Merge branch 'release-9.6.0' into better-rc
shawnbot Oct 12, 2017
9c38043
Merge branch 'release-9.6.0' into better-rc
shawnbot Oct 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add commit status notifications
  • Loading branch information
@shawnbot
shawnbot committed Oct 12, 2017
commit 7413bcf71339dc465f6684e468a42fe2933c257d
12 changes: 11 additions & 1 deletion script/release-candidate
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,13 @@ const getUpdated = (args) => {
.then(updated => updated.map(pkg => pkg.name))
}

const notify = status => {
return execa('script/notify', ['error'])
.catch(error => {
console.error('notify error:', error)
})
}

const writePackage = (pkg) => {
const {dir} = pkg
delete pkg.dir
Expand Down Expand Up @@ -127,9 +134,12 @@ revertPackages()
})
return Promise.all(tasks)
})
.then(() => notify('success'))
})
})
.catch(error => {
console.error('Error:', error)
process.exit(1)
process.exitCode = 1
return notify('error')
})
.then(() => process.exit())