Skip to content

Add 'Popover' component #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Nov 7, 2017
Merged

Add 'Popover' component #383

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
6e350f8
Added `Fixes #` into the PR template
agisilaos Oct 19, 2017
9e13c39
Make a checklist out of the 3 sentences
agisilaos Oct 19, 2017
478f764
Added a space between the # and the (
agisilaos Oct 19, 2017
5dbec5c
Merge pull request #374 from agisilaos/agis/prtemplate
jonrohan Oct 23, 2017
23e4fbc
Merge branch 'master' into dev
jonrohan Oct 24, 2017
ea3ed60
Init .Popover
brandonrosage Oct 26, 2017
17d1a9f
Stable CSS-only 'Popover' component
brandonrosage Oct 27, 2017
4500309
Refactored to include `.Popover-message`
brandonrosage Oct 27, 2017
a7a8a4f
STorybook menu naming revision
brandonrosage Oct 27, 2017
760ceb1
Tweak caret alignment to overlap border.
brandonrosage Oct 27, 2017
13bf797
make Popover positioning more flexible
brandonrosage Nov 2, 2017
d23ce98
Support for top, right, left, bottom caret orientations
brandonrosage Nov 3, 2017
529fdb6
build error fix
brandonrosage Nov 3, 2017
4c6e9f0
Addresses @broccolini's feedback
brandonrosage Nov 3, 2017
dc3ab87
Tweak caret alignment
brandonrosage Nov 6, 2017
d4e6313
Reconciling documentation differences from Style Guide
brandonrosage Nov 6, 2017
6ae4002
Addresses @broccolini's feedback
brandonrosage Nov 6, 2017
ee50150
add peer dependency for Box component
broccolini Nov 7, 2017
dac9464
add toc
broccolini Nov 7, 2017
15d89f3
missed a couple of spacers
broccolini Nov 7, 2017
06feed4
Merge branch 'release-10.0.0' into popover
broccolini Nov 7, 2017
f7a9309
missed a comma
broccolini Nov 7, 2017
4938e89
update year on license
broccolini Nov 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make Popover positioning more flexible
  • Loading branch information
@brandonrosage
brandonrosage committed Nov 2, 2017
commit 13bf79720f05bca05b0e8920e8befc1f09bbb6b1
9 changes: 5 additions & 4 deletions modules/primer-popover/lib/popover.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
.Popover {
position: absolute;
right: 0;
left: 0;
z-index: 100;
}

.Popover-message {
position: relative;
max-width: 235px;
width: 235px;
Copy link
Contributor

@broccolini broccolini Nov 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to make this an even number, suggest making this 232px or 24px—something divisible by 8px because that's what our spacing scale is based on. I know you based this on the original custom code, let me know if you this would cause issues, if so, we can adjust in a follow-up relelase.

margin-right: auto;
margin-left: auto;

Expand Down Expand Up @@ -70,5 +68,8 @@
}

.Popover-message--lg {
Copy link
Contributor

@broccolini broccolini Nov 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this being used? In the docs it says it's a slightly larger option, but that's wrapped in a media query and not mentioned. If it's about the width and not the breakpoint, we should say --large. Also I'd prefer this was divisible by 8 as well—does it work at 320px?

max-width: 330px;

@include breakpoint(sm) {
min-width: 330px;
}
}