-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Button border-radius fix #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e12abf9
add border radius rule to base to override chroma macOS
broccolini 3921628
add button type selector to button stories
broccolini c15cb3b
Revert "add button type selector to button stories"
broccolini 75a32b9
Revert "add border radius rule to base to override chroma macOS"
broccolini 8d0a13e
add border radius rule to base to override chroma macOS
broccolini fd6b4a2
add button type selector to button stories
broccolini e22561a
add changelog back to primer-css module so can pull into docs
broccolini 613afcf
update changelogs
broccolini 1fefabb
add ava to dev dependencies for styelint config
broccolini fa6701d
point build status badge at primer-css
broccolini 65a1be7
add publish script as fall back
broccolini 24763f4
move button story to base
broccolini 3031c97
remove changelog from primer-css because it should copy over automati…
broccolini 4d6138c
remove ava from dev dependencies
broccolini 30aee1a
Merge branch 'release-10.0.0' into btn_fix
broccolini c6abba0
move dev dependency to top level
jonrohan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -64,4 +64,6 @@ th { | |
|
|
||
| button { | ||
| cursor: pointer; | ||
| // Remove border radius added by Chroma macOS | ||
| border-radius: 0; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import React from 'react' | ||
| import { storiesOf } from '@storybook/react' | ||
|
|
||
| storiesOf('Base', module) | ||
| .add('button', () => ( | ||
| <button>Button</button> | ||
| )) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍