Add Sass key to package.json #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonrohan
approved these changes
Dec 7, 2017
There was a problem hiding this comment.
Looks good, but you should add those changes to the generator module https://github.com/primer/primer/blob/sass_key/tools/generator-primer-module/app/templates/package.json#L12 so there's not new modules with old code.
👍 |
astorije
added a commit
to thelounge/thelounge
that referenced
this pull request
Dec 29, 2017
Only changes between v1.5.0 and v1.5.1 (according to https://github.com/primer/primer/commits/master/modules/primer-tooltips) are: - primer/css#394 - primer/css#409 So we are not affected.
crosma
pushed a commit
to crosma/lounge
that referenced
this pull request
Jan 8, 2018
Only changes between v1.5.0 and v1.5.1 (according to https://github.com/primer/primer/commits/master/modules/primer-tooltips) are: - primer/css#394 - primer/css#409 So we are not affected.
This was referenced Mar 21, 2018
This was referenced Dec 14, 2022
This was referenced Jan 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr follows up #394 and adds a Sass key to point to
index.scssin each module.Also added missing file info and updated the keywords for the
branch-namemodule.cc @koddsson @josh