[Fix] Storybook is failing the build #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnbot
reviewed
Jul 3, 2018
script/publish-storybook
Outdated
| repo: `https://primer-css:${process.env.GH_TOKEN}@github.com/primer/storybook` | ||
| }, (error) => { | ||
| if(error) { | ||
| console.log('gh-pages failed to publish:', error) |
There was a problem hiding this comment.
I'm not sure if any of the possible errors includes the repo URL in it, but just in case could we replace the value of $GH_TOKEN with a placeholder in error.message? E.g.
const {GH_TOKEN} = process.env
const pattern = new RegExp(GH_TOKEN, 'g')
const placeholder = '${GH_TOKEN}'
console.error('gh-pages failed to publish:', error.message.replace(pattern, placeholder))There was a problem hiding this comment.
Also, we should set process.exitCode = 1 here, otherwise we'll get false positives on Travis.
shawnbot
approved these changes
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When storybook fails to publish the build is failing, This PR is going to address it by catching the error.
@emplums @shawnbot