Add !important to [hidden] #557
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference #467.
While the issue with
.d-*styles need to be sorted out, having this!importantnow would help us with the many cases that we have already encountered with.btn[hidden], wheredisplay: inline-blocktakes precedence over[hidden].Related but I don't want this to be a blocker – what do y'all think about just duplicating
[hidden] {display: none !important;}at the end ofvisibility-display.scss? Considering these packages can be used separately and this is just one line of code 🤷🏻 IMO it's not horrible. 😬https://github.com/primer/primer/blob/efddb570a8623458b2ca10da6c7bbfd965712c2b/modules/primer-utilities/lib/visibility-display.scss#L30