Skip to content

Add HTML hidden attribute docs, increase [hidden] selector specificity #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 13, 2018
Merged

Add HTML hidden attribute docs, increase [hidden] selector specificity #561

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
07413c4
add docs for HTML hidden per #467
shawnbot Aug 23, 2018
ac5eb73
Merge branch 'release-10.9.0' into add-hidden-docs
shawnbot Oct 16, 2018
e74d093
Merge branch 'release-10.9.0' into add-hidden-docs
shawnbot Oct 17, 2018
c8fd568
Merge branch 'release-10.10.0' into add-hidden-docs
shawnbot Oct 26, 2018
3f65afd
update docs for display utils + [hidden]
shawnbot Oct 26, 2018
f3c4d3e
duplicate [hidden]{display:none!important} in primer-utilities
shawnbot Oct 26, 2018
622a20b
Remove [hidden] duplication from primer-utilities
shawnbot Nov 13, 2018
0d96a80
Add [hidden][hidden] { display: none !important}
shawnbot Nov 13, 2018
2784f0b
update [hidden] docs
shawnbot Nov 13, 2018
25f0a99
Merge branch 'release-10.10.0' into add-hidden-docs
shawnbot Nov 13, 2018
913ae29
rebuild package-lock
shawnbot Nov 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
duplicate [hidden]{display:none!important} in primer-utilities
  • Loading branch information
@shawnbot
shawnbot committed Oct 26, 2018
commit f3c4d3e9f9a3b459cf905a5956e484c873009be5
10 changes: 7 additions & 3 deletions modules/primer-utilities/lib/visibility-display.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,14 @@ $display-values: (
}
}

// Visibility utilities
/* Visibility hidden */
/**
* This is duplicated here so that elements with the HTML5 hidden attribute are
* _always_ display: none, even when one of the .d-* display utilities is in
* play. This works because [hidden] and .d-* have the same CSS specificity.
*/
[hidden] { display: none !important; }

.v-hidden { visibility: hidden !important; }
/* Visibility visible */
.v-visible { visibility: visible !important; }

// Hide utilities for each breakpoint
Expand Down