Skip to content

Updates to Marketing Typography #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 23, 2019
Merged

Updates to Marketing Typography #583

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
818e224
Replace Roboto with Inter and include new sizing
Oct 17, 2018
c74df8e
Delete alt-text-small
Oct 17, 2018
d00f39a
Update docs
Oct 17, 2018
41091ce
ci fix
Oct 25, 2018
7131b7f
remove mono from docs
Oct 25, 2018
4586559
add !important to text-mono class
gladwearefriends Nov 26, 2018
7417eff
add fonts
gladwearefriends Jan 22, 2019
b11ac89
update font file url
gladwearefriends Jan 22, 2019
ee6f771
Merge branch 'master' into marketing-type-2018
gladwearefriends Jan 22, 2019
1a7850c
fix: add fonts dir to npm files list
shawnbot Jan 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/primer-utilities/lib/typography.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@

/* Set to monospace font */
.text-mono {
font-family: $mono-font;
font-family: $mono-font !important;
Copy link
Contributor

@gladwearefriends gladwearefriends Nov 26, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding a note for my commit:
!important is needed in order for the monospace font to have effect with other marketing headers, e.g. h2-mktg when you want a big monospace header like on github.com/ten https://github.com/github/github/pull/102693#discussion_r236315756

https://github.com/github/github/pull/102693/files#diff-20a6e07f77d51d5f093dded1d213d52dR70

}

/* Disallow user from selecting text */
Expand Down