Skip to content

Conversation

@broccolini
Copy link
Contributor

@broccolini broccolini commented Mar 19, 2019

Started this pr because I was testing something, @simurai or @shawnbot could you take this over and ship? Not urgent but fairly low effort.

Ref https://github.com/github/design-systems/issues/596

The bg-yellow-dark utility and variable to replace bg-pending, and text-yellow utility and variable to replace text-pending. These are using in a fair few places in dotcom so will need to update there before deprecating.

To do:

  • update docs
  • update stories (if we need to?)
  • add deprecation warning so can deprecate in a major release

@simurai
Copy link
Contributor

simurai commented Mar 20, 2019

Docs update:

Utility Screenshot
.text-yellow image
.bg-yellow-dark image
.bg-yellow-dark image

@simurai
Copy link
Contributor

simurai commented Mar 20, 2019

Ok, I think this is ready for the next minor (12.3.0) release.

@simurai simurai changed the base branch from release-12.2.1 to master March 20, 2019 09:04
@simurai simurai changed the title [WIP] Add new yellow utilities and variables Add new yellow utilities and variables Mar 22, 2019
@shawnbot shawnbot mentioned this pull request Apr 29, 2019
13 tasks
Co-Authored-By: simurai <simulus@gmail.com>
@simurai simurai requested a review from shawnbot May 1, 2019 00:53
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants