Skip to content

Add More Pink to Primer! 💖🌸💕🌷💞🎀💗🌺💝 #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 30, 2019
Merged

Add More Pink to Primer! 💖🌸💕🌷💞🎀💗🌺💝 #778

merged 5 commits into from
Apr 30, 2019

Conversation

@emplums
Copy link
Contributor

@emplums emplums commented Apr 30, 2019

This PR adds the full pink scale as variables, as well as a bg and color utility using pink-500 :)

/cc @primer/ds-core

@emplums emplums requested a review from broccolini April 30, 2019 20:17
@emplums emplums changed the base branch from master to release-12.3.0 April 30, 2019 20:18
@shawnbot
Copy link
Contributor

shawnbot commented Apr 30, 2019

@emplums Yay! I updated the branch to get the changes from #760. Could you add a $pinks map at and add pink: $pinks to $hue-maps? 🙏

@shawnbot shawnbot mentioned this pull request Apr 30, 2019
Merged
13 tasks
@emplums emplums requested a review from shawnbot April 30, 2019 21:11
@emplums
Copy link
Contributor Author

emplums commented Apr 30, 2019

Thanks @shawnbot, done! Mind giving this a 👍 ?

shawnbot
shawnbot approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so metal

@shawnbot shawnbot merged commit 8da8008 into release-12.3.0 Apr 30, 2019
@shawnbot shawnbot deleted the more-pink branch May 9, 2019 20:44
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Open
This was referenced Dec 20, 2022
Open
Open
This was referenced Dec 31, 2022
Open
Open
@github-actions github-actions bot mentioned this pull request Jan 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@broccolini broccolini Awaiting requested review from broccolini

1 more reviewer

@shawnbot shawnbot shawnbot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Tag: Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emplums @shawnbot