Skip to content

Improve Select Menu spacing #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 23, 2019
Merged

Improve Select Menu spacing #844

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f48d63f
Make (left) icons optional
simurai Jul 22, 2019
57178b8
Add icons to all buttons
simurai Jul 22, 2019
5a05ab5
Merge branch 'master' into select-menu-spacing
simurai Aug 22, 2019
7aa838b
Use flexbox for the items
simurai Aug 22, 2019
887b233
Update select-menu.md
simurai Aug 22, 2019
0577196
Use spacing variable
simurai Aug 23, 2019
ec86465
Add empty commit to re-run checks
simurai Aug 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use spacing variable
  • Loading branch information
@simurai
simurai committed Aug 23, 2019
commit 05771960c661586e8f0cce5145c1cc4509be6299
2 changes: 1 addition & 1 deletion src/select-menu/select-menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@
// The icon shown on the left of a list item. Typically a check icon.

.SelectMenu-icon {
width: 16px; // fixed width to make sure following content aligns
width: $spacer-3; // fixed width to make sure following content aligns
margin-right: $spacer-2;
visibility: hidden;
transition: transform 0.12s cubic-bezier(0.5, 0.1, 1, 0.5), visibility 0s 0.12s linear;
Expand Down